This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
Rename HasBlock to NotifyNewBlocks, and make it accept multiple blocks #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal here is twofold: - allows for batched handling of multiple blocks at once - act as a noisy signal for the breaking change that Bitswap is not adding blocks in the blockstore itself anymore (see ipfs/go-bitswap#571)
|
Also, unless I'm missing something, |
Stebalien
reviewed
Jul 13, 2022
interface.go
Outdated
| // available on the network? | ||
| HasBlock(context.Context, blocks.Block) error | ||
| // NotifyNewBlocks tells the exchange that new blocks are available and can be served. | ||
| NotifyNewBlocks(ctx context.Context, blocks ...blocks.Block) error | ||
|
|
||
| IsOnline() bool |
There was a problem hiding this comment.
Let's drop this. It literally isn't used anywhere.
Stebalien
approved these changes
Jul 13, 2022
MichaelMure
added a commit
to MichaelMure/go-ipfs-exchange-offline
that referenced
this pull request
Jul 14, 2022
Signed-off-by: Jorropo <[email protected]>
Jorropo
pushed a commit
to MichaelMure/go-ipfs-exchange-offline
that referenced
this pull request
Jul 27, 2022
Jorropo
pushed a commit
to ipfs/go-libipfs-rapide
that referenced
this pull request
Mar 23, 2023
Follows: - ipfs/go-ipfs-exchange-interface#23 - ipfs/go-bitswap#571 This commit was moved from ipfs/go-ipfs-exchange-offline@678648a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is twofold: